Use GitHub App authentication for promotion validation - #17569
Open
missymessa wants to merge 2 commits into
Open
missymessa wants to merge 2 commits into
missymessa wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9d4901ab-a32c-4ce3-8cf2-b6f4c1a6e8b5
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Production authentication and rollout depend on pending infrastructure validation and explicit approval.
Pull request overview
Replaces the promotion validator’s GitHub PAT with a short-lived GitHub App token and limits validation to the internal official pipeline.
Changes:
- Mints and passes the installation token to
darc update-dependencies. - Gates promotion validation behind an opt-in parameter.
- Registers the GitHub App secret projections.
File summaries
| File | Description |
|---|---|
eng/validation/validate-promotion.ps1 |
Uses the GitHub token for dependency updates. |
eng/validate-promotion.yml |
Mints and supplies the App token. |
eng/build.yml |
Adds opt-in promotion-validation gating. |
azure-pipelines.yml |
Enables validation for official builds. |
.vault-config/product-builds-engkeyvault.yaml |
Registers the GitHub App secret. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
akoeplinger
previously approved these changes
Sep 16, 2026
Resolve the promotion-validation conflicts in favor of the short-lived GitHub App token while preserving the PAT recovery changes now on main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9d4901ab-a32c-4ce3-8cf2-b6f4c1a6e8b5
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
It changes production credential/authentication plumbing in official pipelines and requires an official-build canary run to validate the end-to-end darc GitHub access path.
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0 new
- Review effort level: Lite
missymessa
marked this pull request as ready for review
September 18, 2026 00:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace Arcade promotion validation's Maestro PAT with a short-lived GitHub App installation token.
arcade-promotion-validation-appas a Secret Manager-managed GitHub App secretget-github-app-token.ymltemplatedarc update-dependenciesfor authenticated common-script retrievalProvisioned infrastructure
4967959162277210, selected-repository mode, exactlydotnet/arcadecontents: read,metadata: readdnceng-arcade-promotion-githubappid-dnceng-arcade-promotion-githubappKey Vault Secrets Useron only the App ID and private-key secret projectionsCompleted prerequisites
dotnet/arcadeand verify effective accessdotnetorganization; the native installation is already completemainafter temporary PAT recovery PR Restore GitHub credential for promotion validation #17568 and resolve the promotion-validation conflicts in favor of the App tokenRequired before merge
Post-merge validation and cleanup
arcade-official-cibuild whose active promotion-validation path reachesRemote.GetCommonScriptFilesAsyncBotAccount-dotnet-maestro-bot-PATDoneTracks DNCENG 12416.