Update Arcade MicrosoftTestingPlatformVersion to stable 2.4.0 - #17542
Open
akoeplinger with Copilot wants to merge 3 commits into
Open
akoeplinger with Copilot wants to merge 3 commits into
akoeplinger with Copilot wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: akoeplinger <1376924+akoeplinger@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update MicrosoftTestingPlatformVersion to stable 2.4.0
Update Arcade MicrosoftTestingPlatformVersion to stable 2.4.0
Sep 11, 2026
akoeplinger
approved these changes
Sep 11, 2026
akoeplinger
marked this pull request as ready for review
September 11, 2026 18:48
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The xUnit V3 target uses this property for the VSTest adapter, so the dedicated runner-version property should be used before merging.
Review details
Suppressed comments (1)
src/Microsoft.DotNet.Arcade.Sdk/tools/DefaultVersions.props:89
- This property is also consumed by
src/Microsoft.DotNet.Arcade.Sdk/tools/XUnitV3/XUnitV3.targets:25as thexunit.runner.visualstudioversion whenUseVSTestRunneris enabled. Bumping it here therefore changes the VSTest adapter to 2.4.0 instead of the separately maintainedXUnitRunnerVisualStudioVersion(4.0.0-pre.4), so an MTP-only update can select the wrong adapter for xUnit v3; make that target use the dedicated runner-version property before merging.
<MicrosoftTestingPlatformVersion Condition="'$(MicrosoftTestingPlatformVersion)' == ''">2.4.0</MicrosoftTestingPlatformVersion>
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The version property also unintentionally changes the xUnit Visual Studio runner through an incorrect existing reference.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
|
|
||
| <XUnitV3Version Condition="'$(XUnitV3Version)' == ''">4.0.0-pre.81</XUnitV3Version> | ||
| <MicrosoftTestingPlatformVersion Condition="'$(MicrosoftTestingPlatformVersion)' == ''">2.2.3</MicrosoftTestingPlatformVersion> | ||
| <MicrosoftTestingPlatformVersion Condition="'$(MicrosoftTestingPlatformVersion)' == ''">2.4.0</MicrosoftTestingPlatformVersion> |
…n XUnitV3.targets Co-authored-by: akoeplinger <1376924+akoeplinger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To double check:
2.2.3to released2.4.0in the two synchronized version definitions, so downstream cleanup tracked indotnet/dotnet#8207can proceed without preview/test-tools dependency assumptions.src/Microsoft.DotNet.Arcade.Sdk/tools/DefaultVersions.props:MicrosoftTestingPlatformVersion→2.4.0Directory.Packages.props: synchronized override →2.4.02.4.0availability for:Microsoft.Testing.PlatformMicrosoft.Testing.Platform.MSBuildMicrosoft.Testing.Extensions.TrxReportInvokeTestingPlatformapphost runtime selection behavior (DOTNET_ROOT_<ARCH>fromDOTNET_HOST_PATHpath).