Skip to content

Update Arcade MicrosoftTestingPlatformVersion to stable 2.4.0 - #17542

Open
akoeplinger with Copilot wants to merge 3 commits into
mainfrom
copilot/update-microsofttestingplatformversion-240
Open

akoeplinger with Copilot wants to merge 3 commits into
mainfrom
copilot/update-microsofttestingplatformversion-240

Conversation

Copilot AI commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

To double check:

  • The right tests are in and the right validation has happened. Guidance: https://github.com/dotnet/arcade/blob/main/Documentation/Validation.md
  • Description: Move Arcade’s MTP pin from 2.2.3 to released 2.4.0 in the two synchronized version definitions, so downstream cleanup tracked in dotnet/dotnet#8207 can proceed without preview/test-tools dependency assumptions.
  • Changes
    • Version source of truth updates
      • src/Microsoft.DotNet.Arcade.Sdk/tools/DefaultVersions.props: MicrosoftTestingPlatformVersion2.4.0
      • Directory.Packages.props: synchronized override → 2.4.0
    • Synchronization scope
      • Kept xUnit/MTP dependency graph intact; no unrelated xUnit or tooling version changes.
    • Release/feed confirmation
      • Confirmed 2.4.0 availability for:
        • Microsoft.Testing.Platform
        • Microsoft.Testing.Platform.MSBuild
        • Microsoft.Testing.Extensions.TrxReport
      • Verified in both nuget.org and dotnet-public.
    • Upstream fix inclusion
      • Verified released line includes InvokeTestingPlatform apphost runtime selection behavior (DOTNET_ROOT_<ARCH> from DOTNET_HOST_PATH path).
<!-- before -->
<MicrosoftTestingPlatformVersion>2.2.3</MicrosoftTestingPlatformVersion>

<!-- after -->
<MicrosoftTestingPlatformVersion>2.4.0</MicrosoftTestingPlatformVersion>

Copilot AI lite review requested due to automatic review settings September 11, 2026 18:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: akoeplinger <1376924+akoeplinger@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 11, 2026 18:46
Copilot AI changed the title [WIP] Update MicrosoftTestingPlatformVersion to stable 2.4.0 Update Arcade MicrosoftTestingPlatformVersion to stable 2.4.0 Sep 11, 2026
Copilot AI requested a review from akoeplinger September 11, 2026 18:47
@akoeplinger
akoeplinger marked this pull request as ready for review September 11, 2026 18:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The xUnit V3 target uses this property for the VSTest adapter, so the dedicated runner-version property should be used before merging.

Review details

Suppressed comments (1)

src/Microsoft.DotNet.Arcade.Sdk/tools/DefaultVersions.props:89

  • This property is also consumed by src/Microsoft.DotNet.Arcade.Sdk/tools/XUnitV3/XUnitV3.targets:25 as the xunit.runner.visualstudio version when UseVSTestRunner is enabled. Bumping it here therefore changes the VSTest adapter to 2.4.0 instead of the separately maintained XUnitRunnerVisualStudioVersion (4.0.0-pre.4), so an MTP-only update can select the wrong adapter for xUnit v3; make that target use the dedicated runner-version property before merging.
    <MicrosoftTestingPlatformVersion Condition="'$(MicrosoftTestingPlatformVersion)' == ''">2.4.0</MicrosoftTestingPlatformVersion>
  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The version property also unintentionally changes the xUnit Visual Studio runner through an incorrect existing reference.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Balanced


<XUnitV3Version Condition="'$(XUnitV3Version)' == ''">4.0.0-pre.81</XUnitV3Version>
<MicrosoftTestingPlatformVersion Condition="'$(MicrosoftTestingPlatformVersion)' == ''">2.2.3</MicrosoftTestingPlatformVersion>
<MicrosoftTestingPlatformVersion Condition="'$(MicrosoftTestingPlatformVersion)' == ''">2.4.0</MicrosoftTestingPlatformVersion>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot address this comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 9ebe7e2XUnitV3.targets now uses $(XUnitRunnerVisualStudioVersion) for xunit.runner.visualstudio instead of $(MicrosoftTestingPlatformVersion).

…n XUnitV3.targets

Co-authored-by: akoeplinger <1376924+akoeplinger@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 11, 2026 19:31
Copilot AI requested a review from akoeplinger September 11, 2026 19:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The synchronized version update and runner-reference correction are consistent and have no unresolved issues.

Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants