[build] serialize Windows library builds - #1544
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to Windows-only MSBuild node count for the relevant build task and directly addresses the reported shared-AAR concurrency failures.
Pull request overview
This PR reduces intermittent Windows-only build failures caused by concurrent MSBuild project builds that contend over shared generated .aar artifacts during AndroidX solution builds.
Changes:
- Limits MSBuild parallelism to a single node on Windows for the
libstask (SetMaxCpuCount(1)). - Updates the inline comment to clarify the specific reason for Windows serialization (shared
.aaraccess across dependent bindings).
File summaries
| File | Description |
|---|---|
| build/cake/build-and-package.cake | Serializes the Windows libs AndroidX solution build by setting MSBuild max CPU count to 1 to avoid shared .aar locking/corruption races. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
jonathanpeppers
enabled auto-merge (squash)
September 10, 2026 21:33
Member
Author
|
@dalexsoto review |
dalexsoto
approved these changes
Sep 11, 2026
dalexsoto
left a comment
dalexsoto
left a comment
Member
There was a problem hiding this comment.
Reviewed the serialized Windows package-build change and its pipeline coverage; no high-confidence correctness blockers remain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows package builds can run bindings that access the same generated AAR concurrently. The two-node limit still permits that race, producing intermittent XARLP7024 file-lock failures before signing and BAR registration.
Serialize the Windows AndroidX solution build with one MSBuild node while leaving non-Windows build parallelism unchanged.
Reference failures:
Xamarin.Google.MLKit.PoseDetection.Common.aar.