fix(generate): use commit subject as PR title and stop masking failures - #281
Closed
dodo-squirrels[bot] wants to merge 1 commit into
Closed
fix(generate): use commit subject as PR title and stop masking failures#281dodo-squirrels[bot] wants to merge 1 commit into
dodo-squirrels[bot] wants to merge 1 commit into
Conversation
On 2026-09-01 the open_prs job reported success while opening ZERO of 9 SDK PRs. Two independent defects combined: 1. pr_title was the FULL commit message. A 1039-char, 20-line body exceeded GitHub's 256-char title limit, so createPullRequest rejected every call. Now only the subject line is used, truncated to 256 chars. 2. The failure was swallowed by `|| echo "PR create skipped (likely already exists / no diff)"`. That message was wrong by construction: the loop already queries for an existing PR and only calls create when none is found, so "already exists" cannot be the cause. The only benign failure left is an empty diff; everything else now prints the real gh error and fails the job. The docs PR had the same masking pattern. Its branch is unique per run and the no-diff case exits earlier, so any failure there is real -- it now fails the job instead of logging a benign-sounding skip. Verified against the actual message that broke it: 1039 chars -> rejected, 58-char subject -> accepted; a 411-char single-line subject truncates to 256. Stainless-Generated-From: 17e0bd9
Member
|
Closing: this branch forked from a base behind current main (behind_by=4), so merging it would revert the 1.115.0 release artifacts. It was produced by a workflow-validation run of stlc-generate.yml, not by a spec change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated stlc build from config repo commit 5a81189507fa5b3732c5f2dce5308a786e88f217.