Skip to content

sbx: governance#25016

Merged
dvdksn merged 1 commit into
docker:mainfrom
dvdksn:sbx-governance
May 11, 2026
Merged

sbx: governance#25016
dvdksn merged 1 commit into
docker:mainfrom
dvdksn:sbx-governance

Conversation

@dvdksn
Copy link
Copy Markdown
Contributor

@dvdksn dvdksn commented May 11, 2026

Adds information about org governance/policy features with sbx.

Stacked on #24978

Preview: https://deploy-preview-25016--docsdocker.netlify.app/ai/sandboxes/security/governance/

@netlify
Copy link
Copy Markdown

netlify Bot commented May 11, 2026

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 6f2dc86
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/6a01fdade2d8bb00070e5e2d
😎 Deploy Preview https://deploy-preview-25016--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown

@docker-agent docker-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The PR adds organization governance/policy documentation for AI Sandboxes, including a new governance.md page, updated security index, policy command documentation, and cross-references across existing pages.

Review summary:

  • Documentation content is accurate and well-structured
  • Front matter (title, description, keywords) is present on all new/modified pages
  • No broken internal links or incorrect commands detected
  • No style guide violations (hedge words, AI-isms, marketing speak) in the added lines
  • The data/sbx_cli/ YAML edits are appropriate — this directory is not listed as vendored in AGENTS.md (only data/cli/ is vendored), and the edits are consistent with a Docker maintainer adding new governance feature documentation

No issues found that require changes.

@dvdksn dvdksn marked this pull request as ready for review May 11, 2026 09:56
@dvdksn dvdksn requested a review from a team May 11, 2026 09:56
@dvdksn dvdksn added the status/review Pull requests that are ready for review label May 11, 2026
Copy link
Copy Markdown

@docker-agent docker-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🔴 CRITICAL

1 critical finding (vendored files manually edited) + 2 medium findings in governance.md.

Comment thread data/sbx_cli/sbx_policy_allow_network.yaml Outdated
Comment thread content/manuals/ai/sandboxes/security/governance.md Outdated
Comment thread content/manuals/ai/sandboxes/security/governance.md Outdated
Comment thread content/manuals/ai/sandboxes/security/governance.md Outdated
Comment thread content/manuals/ai/sandboxes/security/governance.md Outdated
@dvdksn dvdksn requested a review from usha-mandya May 11, 2026 10:42
Comment thread content/manuals/ai/sandboxes/security/governance.md
Copy link
Copy Markdown

@docker-agent docker-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟡 NEEDS ATTENTION

3 medium findings in new content. No high-severity issues. No vendored files touched, no missing redirects.

Comment thread content/manuals/ai/sandboxes/security/governance.md Outdated
Comment thread content/manuals/ai/sandboxes/security/governance.md Outdated
Comment thread content/manuals/ai/sandboxes/security/policy.md Outdated
Comment thread content/manuals/ai/sandboxes/security/governance.md
Copy link
Copy Markdown
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread content/manuals/ai/sandboxes/faq.md
@usha-mandya usha-mandya requested a review from smnovick May 11, 2026 15:14
Copy link
Copy Markdown

@docker-agent docker-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The changes introduce a new governance.md page and link it from 7 existing files. The content is accurate, well-structured, and consistent with Docker documentation style.

No actionable issues found. The precedence model is correctly documented (org rules take precedence, with delegation carve-outs explained immediately after the general statement), and the troubleshooting section correctly describes the automatic daemon restart flow after sbx policy reset.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn enabled auto-merge May 11, 2026 16:03
@dvdksn dvdksn merged commit 623e0a9 into docker:main May 11, 2026
13 checks passed
@dvdksn dvdksn deleted the sbx-governance branch May 11, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants