Skip to content

image push: respect NO_COLOR in aux notes#6957

Open
WilliamK112 wants to merge 1 commit into
docker:masterfrom
WilliamK112:6890-respect-no-color-push
Open

image push: respect NO_COLOR in aux notes#6957
WilliamK112 wants to merge 1 commit into
docker:masterfrom
WilliamK112:6890-respect-no-color-push

Conversation

@WilliamK112
Copy link
Copy Markdown

@WilliamK112 WilliamK112 commented Apr 25, 2026

Summary

  • route docker image push aux-note coloring through tui.Output
  • respect NO_COLOR when rendering the digest mapping note
  • add a regression test covering terminal output with NO_COLOR=1

Why

Fixes docker image push emitting ANSI color codes in aux-note output even when NO_COLOR is set.

Fixes #6890

Testing

  • added regression test: TestRunPushRespectsNoColorForAuxNotes
  • local static check: git diff --check
  • full Go test execution was not available locally in this environment because go is not installed in PATH here; CI should validate compile/test behavior
`docker image push` now respects `NO_COLOR`

Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
@vvoland vvoland added this to the 29.5.0 milestone May 11, 2026
Copy link
Copy Markdown
Collaborator

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, your commit sign-off needs a real name though.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Respect NO_COLOR for docker image push

3 participants