fix: add missing clap attribute to no_content_indexing (#754) - #765
Merged
Conversation
The no_content_indexing field lacked its #[arg(long = ...)] attribute, so clap treated it as a positional with a SetTrue action. Debug builds panicked on any invocation; release builds exposed [NO_CONTENT_INDEXING] as a positional and rejected --no-content-indexing. Closes #754
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
dmtrKovalenko
approved these changes
Aug 11, 2026
abhijit-s
pushed a commit
to abhijit-s/fff
that referenced
this pull request
Aug 13, 2026
Brings in upstream fixes on top of our 0.18.0 fork: - fix(grep) dmtrKovalenko#756/dmtrKovalenko#764: literal/regex fallback now keeps an explicit FilePath scope so a top-level regex alternation can't leak matches outside the pinned path - fix dmtrKovalenko#754/dmtrKovalenko#765: missing clap attribute on no_content_indexing - fix(bun) dmtrKovalenko#766: proper build step for fff-bun - chore dmtrKovalenko#762: rename stale fff.nvim repo refs to fff Conflicts resolved preserving fork divergences: - update_check.rs / install-mcp.sh: kept our DEFAULT_REPO=abhijit-s/fff and FFF_UPDATE_REPO override; upstream's fff.nvim->fff rename does not apply since we target our own fork for update checks and installs - README.md: kept our rewritten Homebrew-tap/apt/fffctl install section; upstream only tweaked a release URL in a block our fork already removed - grep_tests.rs: add/add at EOF resolved as a union — kept our three cold-start readiness tests and adopted upstream's dmtrKovalenko#756 regex-scope test, reflowing the shared trailing braces so both functions close correctly grep.rs auto-merged; reviewed the dmtrKovalenko#756 fallback change against our surrounding fork logic and confirmed coherence. Makefile .PHONY targets and the per-root ignore feature (ignore.rs/main.rs) preserved; workspace stays at 0.18.0. Build green (fff-mcp/fff-engine/fff-ctl); fff-search + fff-engine tests 375 passed, 0 failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #754
Root cause
crates/fff-mcp/src/main.rs:134declared theno_content_indexing: boolfield without an#[arg(long = ...)]attribute. clap therefore treated it as a positional argument with aSetTrueaction, which is invalid.Fix
Added
#[arg(long = "no-content-indexing")]to the field, matching the adjacent--no-warmup/--no-watchflags.Steps to reproduce
On pre-fix
origin/main(b6f351d):Expected: help text listing a
--no-content-indexingboolean option.Actual (debug build): panic before any output —
Release builds instead expose
[NO_CONTENT_INDEXING]as a positional and reject--no-content-indexing.How verified
Now exits 0 and lists the flag:
Automated triage via Gustav. Honk-Honk 🪿