task-observer: new docs/ai/review from 2026-07-20 - #76
Conversation
Extracts reusable review contracts into a global reference doc: - Scope detection: use project's declared integration branch, not hardcoded main - Finding admissibility: de-scoped features are inadmissible findings - Bug-fix routing: structured learning with root cause, principle, anti-pattern, and enforcement candidate per bug class - Layering: global contracts here, project deltas in <project>/docs/ai/review.md
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 162127b89b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ## Contract | ||
|
|
||
| - Orchestration skills (`/deep-review`, `/fly` gates) say how to run the workflow. This doc holds the reusable contracts for what to look for and how to route findings. |
There was a problem hiding this comment.
Wire review.md into review activation
This new global contract is not loaded by normal review workflows: .claude/AGENTS.md's adaptive-docs table still routes only git/writing/ask-intern/learning, and the only existing review.md routing I found is preflight's generated task pre-reading, while /deep-review still hard-codes main for branch scope. As a result, repos whose integration branch is master/m3 will still get the noisy or wrong review base this doc is meant to prevent unless the review skills or root routing table are updated to read it.
Useful? React with 👍 / 👎.
Target
new-global-doc: docs/ai/review.md
Observations addressed
docs/ai/review.mdwith reusable review contracts covering scope detection (use declared integration branch, not hardcodedmain), finding admissibility (de-scoped features are inadmissible), bug-fix routing (structured learning with root cause, principle, anti-pattern, and enforcement candidate), and the global/project layering contract.Note: AGENTS.md routing table update (
review.mdrow) was skipped because the edit was rejected.Generated by Claude Code