fix(app): colour canceled timeline placeholders amber - #322
Merged
Conversation
A run timeline row with no bar (the execution never started) rendered as the same neutral dashed outline regardless of status, so a canceled operation was indistinguishable from a still-queued one except in the tooltip. Since 0.74.0 every never-submitted operation of a fail-fast run is canceled, so this now shows on every failed multi-asset run. The placeholder takes its outline from the row status: canceled uses the warning (amber) tokens, matching the Canceled pill; queued and skipped keep the neutral dashed look. By Digitl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A run timeline row with no bar (the execution never started) rendered as the same neutral dashed outline regardless of status. A canceled operation was indistinguishable from a still-queued one except in the tooltip.
Since 0.74.0 (#309) every never-submitted operation of a fail-fast run is canceled, so this now shows on every failed multi-asset run. Prod run
e65b8d04(Amazon SP, 72 canceled) is a typical example.Fix
The placeholder takes its outline from the row status via a small
placeholderClasshelper inExecutionTimeline.vue:canceled→border-warning bg-warning/10 text-warning(amber, matching the Canceled status pill)queued,skipped) →border-accented text-dimmed, unchangedThe border stays dashed in both cases: it still means "never ran".
Verification
pnpm run lint(one pre-existingv-htmlwarning elsewhere),pnpm exec nuxt typecheckclean.rgb(230, 158, 46)(palette amber-500); the queued one keeps the neutral classes. Light mode only.By Digitl