test(app): cover the static and source asset lookups - #320
Merged
Conversation
interloper-app's Python package had no tests, leaving its two asset-path lookups at 65%. Both resolve from the package location, so the suite relocates `_PACKAGE_DIR` into a temporary tree rather than depending on whether this checkout has run `make build-app`. Add the workspace-standard `tests/**` per-file-ignores entry to the package's ruff config; it was the only package missing it, having had no tests until now. By Digitl
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
interloper-app's Python package had no test suite at all, leaving its two asset-path lookups at 65% (static_dirandsource_direrror paths uncovered). This brings the package to 100%.interloper_appNotes
assets._PACKAGE_DIRinto atmp_pathtree. Asserting against the real checkout would tie the suite to whethermake build-apphas run, and fail on a fresh clone.make build-appmessage, astatic/directory without anindex.html(a stale or partial build must not be served as if it were complete), the Nuxt checkout resolving two levels up, and an installed wheel with no source checkout.packages/interloper-app/pyproject.tomlcarries its own[tool.ruff], and was the only package in the workspace without the"tests/**"per-file-ignoresentry, having had no tests until now. Added the same line the other packages use rather than working around it in the test file.packages/interloper-app/app/is untouched: it has no test runner today, so adding one is a separate decision.Checks
uv run ruff check,uv run ty check,uv run pytest(2583 passed) all green from the repo root.By Digitl