Skip to content

test(app): cover the static and source asset lookups - #320

Merged
aaaaahaaaaa merged 1 commit into
mainfrom
test/interloper-app-coverage
Sep 4, 2026
Merged

test(app): cover the static and source asset lookups#320
aaaaahaaaaa merged 1 commit into
mainfrom
test/interloper-app-coverage

Conversation

@aaaaahaaaaa

Copy link
Copy Markdown
Contributor

What

interloper-app's Python package had no test suite at all, leaving its two asset-path lookups at 65% (static_dir and source_dir error paths uncovered). This brings the package to 100%.

before after
interloper_app 65% 100%

Notes

  • Both lookups resolve relative to the package location, so the suite relocates assets._PACKAGE_DIR into a tmp_path tree. Asserting against the real checkout would tie the suite to whether make build-app has run, and fail on a fresh clone.
  • Covered: a built app resolving, an unbuilt app raising the actionable make build-app message, a static/ directory without an index.html (a stale or partial build must not be served as if it were complete), the Nuxt checkout resolving two levels up, and an installed wheel with no source checkout.
  • packages/interloper-app/pyproject.toml carries its own [tool.ruff], and was the only package in the workspace without the "tests/**" per-file-ignores entry, having had no tests until now. Added the same line the other packages use rather than working around it in the test file.
  • The Nuxt frontend under packages/interloper-app/app/ is untouched: it has no test runner today, so adding one is a separate decision.

Checks

uv run ruff check, uv run ty check, uv run pytest (2583 passed) all green from the repo root.

By Digitl

interloper-app's Python package had no tests, leaving its two asset-path
lookups at 65%. Both resolve from the package location, so the suite
relocates `_PACKAGE_DIR` into a temporary tree rather than depending on
whether this checkout has run `make build-app`.

Add the workspace-standard `tests/**` per-file-ignores entry to the
package's ruff config; it was the only package missing it, having had no
tests until now.

By Digitl
@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@aaaaahaaaaa
aaaaahaaaaa merged commit 2bc6a8a into main Sep 4, 2026
11 checks passed
@aaaaahaaaaa
aaaaahaaaaa deleted the test/interloper-app-coverage branch September 4, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant