chore(deps): update dependency @xterm/xterm to v6.1.0-beta.302 - #390
chore(deps): update dependency @xterm/xterm to v6.1.0-beta.302#390renovate[bot] wants to merge 1 commit into
Conversation
dormouse-bot
left a comment
There was a problem hiding this comment.
Holding approval: this set pins core to a commit no addon was published from, and #389 (open, yours) already lands the coherent version of exactly this bump plus the lint that would have rejected this one.
I checked the gitHead of each pinned version against the registry rather than relying on semver, because semver is precisely what misses this — @xterm/addon-fit@0.12.0-beta.299 declares "@xterm/xterm": "^6.1.0-beta.301", and ^6.1.0-beta.301 happily admits 6.1.0-beta.302, so pnpm install stays silent. The resulting tree spans three upstream commits:
| pin in this PR | published from |
|---|---|
@xterm/xterm@6.1.0-beta.302 |
d6cfe3db |
@xterm/addon-fit@0.12.0-beta.299 |
8c9b9fdb (= core 6.1.0-beta.301) |
@xterm/addon-unicode-graphemes@0.5.0-beta.299 |
8c9b9fdb |
@xterm/addon-webgl@0.20.0-beta.291 (untouched) |
904ae935 (= core 6.1.0-beta.292) |
The addons bundle core internals, so this ships three addons compiled against a core they were not built against — ten betas back, in addon-webgl's case.
Three things make this structural rather than a one-off:
@xterm/addon-webgl can never be in this PR. The xterm group in .github/renovate.json lists @xterm/xterm, @xterm/addon-fit, @xterm/addon-unicode-graphemes by exact name, so the fourth package falls outside a group whose own description says "keep them in one PR". Its newest published beta is 0.20.0-beta.298, from the same 8c9b9fdb as the other two addons — so a coherent set exists and Renovate structurally cannot propose it. #389 fixes this by matching @xterm/** by scope.
This bump removes the only signal that the tree is drifted. On main, addon-webgl@0.20.0-beta.291 peers on ^6.1.0-beta.292 against a core pinned at 6.1.0-beta.291 — an unmet peer that pnpm install reports. Moving core to 6.1.0-beta.302 satisfies it. So the install output goes from warning to quiet while the drift gets wider, which is the worst direction for a check nobody has yet automated.
canopy and the fork are left behind. docs/specs/webgl-text.md § "Following upstream" says of the fork re-evaluation: "Land all of it in the same PR as the @xterm/* bump, so the tree never records a state where lib and the fork disagree about which upstream they track." canopy/package.json is untouched here — still @xterm/xterm@6.1.0-beta.291 and the sdf291.0 fork tarball — so merging this records exactly that state, and canopy's UpstreamVsFork harness starts comparing against an upstream we no longer ship. Renovate can't see the tarball URL, so no Renovate PR will ever satisfy this rule.
My suggestion is to close this in favor of #389 rather than patch it. Repinning core to 6.1.0-beta.301 inline would fix the first row of that table and none of the other three, and Renovate would rebase the edit away on the next branch-creation Monday anyway. Once #389 lands, scripts/xterm-lint.mjs turns this from a review catch into a red check, and the scope-matched group means the next Renovate xterm PR at least carries all four packages.
Verification
Registry queries (run from outside the repo so the root devEngines pin doesn't reject npm):
npm view @xterm/xterm@6.1.0-beta.301 gitHead -> 8c9b9fdb9ba7b72b677173225f69c2a47f807600
npm view @xterm/xterm@6.1.0-beta.302 gitHead -> d6cfe3db5dfdbfd2a08c3f9bcfcde8a283aa479d
npm view @xterm/addon-fit@0.12.0-beta.299 gitHead -> 8c9b9fdb9ba7b72b677173225f69c2a47f807600
npm view @xterm/addon-unicode-graphemes@0.5.0-beta.299 gitHead -> 8c9b9fdb9ba7b72b677173225f69c2a47f807600
npm view @xterm/addon-webgl@0.20.0-beta.291 gitHead -> 904ae935269eef5ec6a1415b64463c3d02eff1eb
npm view @xterm/addon-webgl@0.20.0-beta.298 gitHead -> 8c9b9fdb9ba7b72b677173225f69c2a47f807600
npm view @xterm/addon-webgl dist-tags beta -> 0.20.0-beta.298
Peer ranges as recorded in this PR's own pnpm-lock.yaml: addon-fit@0.12.0-beta.299 and addon-unicode-graphemes@0.5.0-beta.299 → ^6.1.0-beta.301; addon-webgl@0.20.0-beta.291 → ^6.1.0-beta.292. All three are satisfied by 6.1.0-beta.302, which is why CI is green — Build & Test, Standalone Smoketest, Visual Regression Tests and Cloudflare Pages all pass on this head. Nothing in the tree today checks commit coherence.
Files consulted: .github/renovate.json (the xterm group and the canopy-scoped disable), canopy/package.json, canopy/README.md (§ "Dependency rules", § "Regression harness"), docs/specs/webgl-text.md (§ "Following upstream").
f5c8f18 to
10c5426
Compare
Deploying mouseterm with
|
| Latest commit: |
10c5426
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://14bbb18e.mouseterm.pages.dev |
| Branch Preview URL: | https://renovate-xterm.mouseterm.pages.dev |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update ( If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
6.1.0-beta.301→6.1.0-beta.302Release Notes
xtermjs/xterm.js (@xterm/xterm)
v6.1.0-beta.302Compare Source
Configuration
📅 Schedule: (in timezone America/Los_Angeles)
* * * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.