Conversation
For 1.2.0 (unreleased). - Autofill.app_hash(value) / Autofill.none() and SmsOptions.autofill; the deprecated SmsOptions.app_hash maps onto it with a DeprecationWarning and never reaches the wire. - SmsInfo.autofill decodes the echoed marker; SmsInfo.app_hash is derived from it. - autofill_invalid is a known error code.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
README and the SmsInfo.app_hash docstring said the API no longer reads or returns app_hash. It still does, as a deprecated alias of autofill.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For 1.2.0 (unreleased).
deprecated SmsOptions.app_hash maps onto it with a DeprecationWarning and
never reaches the wire.
from it.