feat(switch): add aria-checked attribute - #1761
Open
khalilurrrahmanridoykhan wants to merge 1 commit into
Open
Conversation
The input renders role="switch" but never set aria-checked, which the WAI-ARIA switch pattern requires to reflect toggle state to assistive technology. Mirrors the aria-valuenow fix already shipped for the Loader's role="progressbar" in the same accessibility effort (dhis2#1447).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements LIBS-572, part of the library-wide accessibility effort tracked in #1447.
Description
Switchrendersrole="switch"on its input but never setsaria-checked, which the WAI-ARIA switch pattern requires to communicate toggle state to assistive technology. This mirrors thearia-valuenowfix already shipped forLoader'srole="progressbar"in the same effort (#1449).No prop changes —
aria-checkedis derived from the existingcheckedprop, the same patternLoaderused foraria-valuenow/amount.Was this change primarily generated using an AI tool? Yes — Claude Code, Claude Sonnet 5. 🤖 Used to identify the gap (cross-referencing the WAI-ARIA switch pattern and the merged Loader accessibility PR for precedent), and to draft/verify the fix and test below; I reviewed and understand the change.
Known issues
Checklist
aria-checkedis derived from existingchecked)Screenshots
No visual change —
aria-checkedis a non-visual accessibility attribute.