feat(select): add menuMinWidth and menuMaxWidth to SimpleSingleSelect - #1759
Open
arina-gutuboe wants to merge 2 commits into
Open
feat(select): add menuMinWidth and menuMaxWidth to SimpleSingleSelect#1759arina-gutuboe wants to merge 2 commits into
arina-gutuboe wants to merge 2 commits into
Conversation
|
Contributor
|
🚀 Deployed on https://pr-1759--dhis2-ui.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements LIBS-869
Description
#1744 added
menuMinWidth/menuMaxWidthtoSingleSelectandMultiSelectfor flexible, fit-content menu sizing.This PR adds the same props to
SimpleSingleSelectandSimpleSingleSelectFieldfor consistent behavior across all select variants.Known issues
With only menuMinWidth (no menuMaxWidth), the menu can grow without an upper bound for very long option labels; menuMinWidth and menuMaxWidth should be used together when labels can vary significantly in length.
Checklist
Screenshots
menuMaxWidthis slightly greater than the width of the input, but less than the width of the options:with
menuMinWidth: