PdoDriver: fix escapeBinary() for SQLite binary containing NUL bytes - #475
Open
zeleznypa wants to merge 1 commit into
Open
PdoDriver: fix escapeBinary() for SQLite binary containing NUL bytes#475zeleznypa wants to merge 1 commit into
zeleznypa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PdoDriver::escapeBinary()has nosqlitebranch and falls through toPDO::quote($value, PDO::PARAM_LOB). On PHP 8.5,PDO::quote()returnsfalsefor values containing NUL bytes, which surfaces as aTypeErrorbecause the method is typed: string. This mirrors the nativeSqliteDriver::escapeBinary(), which already uses a hex literalX'...'.Changes:
'sqlite'branch toPdoDriver::escapeBinary()(mirrorsSqliteDriver).tests/dibi/PdoDriver.escapeBinary.phpt.Targeted at
v5.1as it affects the current stable release.PdoDriver::escapeText()has the same structure for SQLite, but binary data should go through%bin/escapeBinary()— happy to extend if you prefer.Note: the red
Tests/Static Analysischecks are pre-existing onv5.1and unrelated to this change —tests/types/dibi-types.phptand PHPStan fail to bootstrap (ServiceCreationException, aphpstan/phpstan↔nette/phpstan-rulesincompatibility).Coding Styleand the newPdoDriver.escapeBinary.phptpass.