docs: clean up and enrich security model documentation#1285
Conversation
The three-tier traceability diagram, compliance-only controls listing, OSCAL artifact links, and control register reference were repeated verbatim in security.rst despite being the authoritative content of the auto-generated compliance_track.rst. Replace with a single forwarding sentence pointing readers to the compliance_track page. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E1Kh1r5dX7VEP6AScUtgrN
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E1Kh1r5dX7VEP6AScUtgrN
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E1Kh1r5dX7VEP6AScUtgrN
Link MIT licence, Article 13 CRA reference, GitHub Actions / GitLab CI / Jenkins CI examples, and OJEU mention to their respective pages. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E1Kh1r5dX7VEP6AScUtgrN
…rectly RST does not support nesting inline roles inside **bold** markup, causing the :ref: role to be emitted as literal text. Switch to .. rubric:: which renders as a bold heading and correctly processes inline markup. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E1Kh1r5dX7VEP6AScUtgrN
…t links Explain what OSCAL is, what problem it solves for downstream integrators, and link directly to both artifact files in the repository. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E1Kh1r5dX7VEP6AScUtgrN
Add three new glossary terms: SDLC, CVE, ECR. Add :term: cross-references in security.rst: replace named external links for CRA/EN 40000/STRIDE with :term: refs; add refs for SDLC, Archive, Manifest, Metadata, Destination, Vendoring, Superproject, OSCAL throughout the body; add a seealso box linking to the glossary. Add :term: refs in security_pipeline.rst for STRIDE, OSCAL, SBOM, SLSA Build/Source Provenance, Sigstore, Attestation, VSA, ECR, Vendoring; add seealso box. Update compliance.py generator to use :term:`OSCAL` in the OSCAL Artifacts section and intro; regenerate compliance_track.rst. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E1Kh1r5dX7VEP6AScUtgrN
|
Warning Review limit reached
More reviews will be available in 50 minutes and 13 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughDocumentation-only update: the ChangesCRA Compliance Docs: Rendering, Narrative, Cross-References, and Glossary
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@doc/explanation/security_pipeline.rst`:
- Line 107: The reStructuredText syntax for pluralizing the glossary term
reference on line 107 is incorrect. In the phrase containing `:term:`ECR`\s`,
the backslash escape sequence is malformed. Change `:term:`ECR`\s` to
`:term:`ECR`\ s` by adding a space after the backslash. The escaped space
(backslash followed by space) properly separates the role markup from the
following character while maintaining valid RST syntax for pluralization.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 94472a36-fa16-4015-8ab1-aec78710bbc3
📒 Files selected for processing (5)
doc/explanation/compliance_track.rstdoc/explanation/security.rstdoc/explanation/security_pipeline.rstdoc/reference/glossary.rstsecurity/compliance.py
`:term:`ECR`\s` is malformed — the backslash escape sequence needs a trailing space: `:term:`ECR`\ s`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E1Kh1r5dX7VEP6AScUtgrN
Summary
compliance_track.rst; replaced with a single forwarding paragraph.compliance_track.rstused**:ref:…**which RST cannot render (inline role inside bold); switched the generator to.. rubric::so the cross-reference links resolve correctly.:term:cross-references for CRA, EN 40000, STRIDE, SDLC, Archive, Manifest, Metadata, Destination, Vendoring, Superproject, OSCAL, SBOM, SLSA, Sigstore, Attestation, VSA, ECR, SARIF throughoutsecurity.rstandsecurity_pipeline.rst; convert thecompliance.pygenerator to use:term:\OSCAL`` in the generated page... seealso::blocks onsecurity.rstandsecurity_pipeline.rstpointing readers to the glossary.Test plan
make -C doc html) and check that all:term:refs resolve without warningscompliance_track.rstrender as bold rubrics with working anchor links🤖 Generated with Claude Code
https://claude.ai/code/session_01E1Kh1r5dX7VEP6AScUtgrN
Generated by Claude Code
Summary by CodeRabbit