docs: update chunk examples to ColumnName keys#202
Merged
Conversation
Follow-up to the writeChunk(Map<ColumnName, Object>) retype (#201) and the Chunk.put(ColumnName, ...) builder (#200): doc snippets still showed String keys and would not compile. DocsConsistencyTest is blind to them (the .put("x", ...) / writeChunk(Map<...>) forms have no dotted receiver its regex can match), so this was caught in review, not CI. - reference.md: writeChunk(Map<String, Object>) -> Map<ColumnName, Object> - README / tutorial / compatibility: .put("x", ...) -> .put(ColumnName.of("x"), ...) - tutorial: add the ColumnName import - JdbcImporter.toChunkMap: drop a pointless ColumnName -> String -> ColumnName round-trip (List<ColumnName> names = schema.fieldNames()) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dfa1
added a commit
that referenced
this pull request
Jul 6, 2026
The Chunk builder row still read put(String column, Object data) but the method has taken ColumnName since #200. A survey of backticked method-signature claims (prompted by the #202 review) surfaced it; #202 fixed the fenced .put snippets but missed this reference table row. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-merge review follow-up to #201 (
writeChunk(Map<ColumnName, Object>)) and #200 (Chunk.put(ColumnName, …)).Several doc snippets still showed
Stringkeys and would not compile against the current API.DocsConsistencyTestis blind to them — the.put("x", …)andwriteChunk(Map<…>)forms have no dotted receiver its method-name regex can match — so this surfaced in review rather than CI.reference.md:writeChunk(Map<String, Object>)→Map<ColumnName, Object>(the update refactor: type writeChunk map keys as ColumnName #201 was obligated to make)README/tutorial/compatibility:.put("x", …)→.put(ColumnName.of("x"), …), plus theColumnNameimport in the tutorialJdbcImporter.toChunkMap: drop a pointlessColumnName → String → ColumnNameround-trip an automated transform left behind —List<ColumnName> names = schema.fieldNames()now matches the cleanCsvImporterformDocsConsistencyTest+ jdbc module build green.🤖 Generated with Claude Code