fix(installer): make managed root check locale independent - #33
Open
Kinetic27 wants to merge 1 commit into
Open
Conversation
devswha
approved these changes
Aug 11, 2026
devswha
left a comment
devswha
left a comment
Owner
There was a problem hiding this comment.
Verified the installer parses stat %F under LC_ALL=C, so localized coreutils output cannot break the exact directory comparison. The one-line change is scoped correctly; sh -n install.sh passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
statmetadata query to use the C locale%Fis localized, such as디렉터리under Korean localesVerification
sh -n install.shLANG=ko_KR.UTF-8Fixes the one-line installer error:
[chatmux] ERROR: managed root must be an ordinary directory