lopper: assists: gen_domain_dts: Allow passing extra zephyr comp file…#776
Conversation
KasperSloth99
force-pushed
the
kslo/patch-lopper-to-take-custom-comp
branch
from
4295530 to
e515373
Compare
|
Hi @onkarharsh please review |
|
environment variable only options are clunky. You can keep the environment variable processing, but also passing it as a command line options makes it much more discoverable and obvious in logs and command lines. |
|
@zeddii I just followed how it is done with f.ex LOPPER_DTC_FLAGS. If you prefer i can do it as a CLI option? |
|
LOPPER_DTC_FLAGS is one of the few environment variables (and for what it is used for, it shouldn't be used like it is anymore, there's a command line equivalent). For something down in the pipeline like an assist, having the option near the assist on the command line helps usability and understandability. |
… via CLI I ran into an issue of not being able to add my own zephyr_supported_comp.yaml file, without having to have my own fork and edit the upstream file. Instead it is much nicer to be able to set the path to your own compatible schema, and have it be part of your own repository. Add a --extra-zephyr-comp <path> argument to the gen_domain_dts assist that can be repeated to merge one or more user-provided YAML files on top of the upstream zephyr_supported_comp.yaml. Later entries override earlier same-key entries. Parsing follows the argparse pattern used in parse_openamp_args so positional arguments to the assist are preserved. Signed-off-by: Kasper Sloth <kslo@ambu.com>
KasperSloth99
force-pushed
the
kslo/patch-lopper-to-take-custom-comp
branch
from
e515373 to
9978b4b
Compare
|
@zeddii I changed it to be a cli argument instead. |
|
This looks good to me. Still waiting on the other review before merging. |
kedareswararao
left a comment
kedareswararao
left a comment
There was a problem hiding this comment.
Changes looks fine to me
3 participants
… through env
I ran into an issue of not being able to add my own zephyr_supported_comp.yaml file, without having to have my own fork and edit the upstream file. Instead it is much nicer to be able to be able to set the path to your own compatible schema, and have it be part of your own repository.