fix(hub-ui): keep dock rail expanded while a group menu is open - #304
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The dock rail's idle auto-collapse ignored open group menu popovers. After the idle timeout the rail would minimize (float mode) or collapse (edge mode) out from under an open group menu, leaving the popover floating and detached from its trigger button.
Why
A group menu anchors to a dock-bar/toolbar button. Collapsing the rail while the menu is open orphans the popover from its trigger, which is jarring and makes the menu appear to hover with no source.
How
Both rail variants in
packages/hub-ui/src/client/components/dock/now consult the existing shareduseDocksGroupPanel()state (set byDockGroupButtonwhen it opens the popover):Dock.vue—isMinimizedreturnsfalsewhile a group menu is open.DockEdge.vue—isCollapsedreturnsfalsewhile a group menu is open.Normal auto-collapse resumes once the menu closes.
This PR was created with the help of an agent.