Skip to content

Update ci image node version to 22.12.0 - #1713

Merged
dkwon17 merged 1 commit into
devfile:mainfrom
dkwon17:update-ci-node
Sep 29, 2026
Merged

dkwon17 merged 1 commit into
devfile:mainfrom
dkwon17:update-ci-node

Conversation

@dkwon17

@dkwon17 dkwon17 commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

This PR should fix the prow ci check failure: https://prow.ci.openshift.org/view/gs/test-platform-results-public/pr-logs/pull/devfile_devworkspace-operator/1711/pull-ci-devfile-devworkspace-operator-main-v14-che-happy-path/2104796873352024064

For more context, the current node version for the ci image was node 16.

What issues does this PR fix or reference?

Is it tested? How?

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

Summary by CodeRabbit

  • Chores
    • Updated the container build to use Node.js 22.12.0 and verify the installed Node.js and npm versions.

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d6e95c0b-217b-4513-add1-3cbafe5e1265

📥 Commits

Reviewing files that changed from the base of the PR and between 44faaff and 4edc911.

📒 Files selected for processing (1)
  • .ci/oci.Dockerfile

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The OCI Dockerfile now installs Node.js 22.12.0 from an architecture-specific distribution archive, creates command symlinks, and checks the Node.js and npm versions. It no longer installs nodejs through yum.

Changes

OCI image Node.js installation

Layer / File(s) Summary
Install the pinned Node.js version
.ci/oci.Dockerfile
The Dockerfile installs Node.js 22.12.0 from the archive for the detected architecture, creates node, npm, and npx symlinks, and checks the Node.js and npm versions. The yum package list no longer includes nodejs.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 4edc9

The OCI image targets amd64 and selects the matching pinned Node.js archive. No merge-blocking risk is established by the supplied evidence.

Architecture Summary

Architecture risk: 🔵 Low · up to 4edc9

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .ci/oci.Dockerfile: Adds installation of Node.js 22.12.0 from the architecture-specific .tar.xz archive, creates node, npm, and npx symlinks, and checks the installed Node and npm versions.
  • observed — Modified behavior in .ci/oci.Dockerfile: Removes nodejs from the yum package list; the other listed packages remain.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: updating the CI image's Node.js version to 22.12.0.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 29, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17, rohanKanojia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: David Kwon <dakwon@redhat.com>
@openshift-ci

openshift-ci Bot commented Sep 29, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@openshift-ci

openshift-ci Bot commented Sep 29, 2026

Copy link
Copy Markdown

@dkwon17: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-che-happy-path 4ecf77e link true /test v14-che-happy-path

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dkwon17
dkwon17 merged commit 3526ad3 into devfile:main Sep 29, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants