feat: switch to rustac - #94
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'TiTiler-STACapi Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.
| Benchmark suite | Current: 5c76b33 | Previous: 09891f7 | Ratio |
|---|---|---|---|
Search-Z2 |
44.004694282940896 iter/sec (stddev: 0.046999819161416316) |
64.9145337301337 iter/sec (stddev: 0.0005444191831955243) |
1.48 |
This comment was automatically generated by workflow using github-action-benchmark.
| and link.media_type == pystac.MediaType.JSON | ||
| ), | ||
| None, | ||
| ) |
There was a problem hiding this comment.
@gadomski in titiler-stacapi, we where using pystac-client/pystac to get the aggregations supported by the API (for the catalog and for each collection).
This submodule, kinda extend the rustac.ApiClient but has to use httpx.get to fetch the response from the API, which will then break if/when we try to support pgstac access directly from rustac.
Q: do you think we could extend rustac.ApiClient to support the aggregation extention natively?
There was a problem hiding this comment.
Q: do you think we could extend rustac.ApiClient to support the aggregation extention natively?
I don't see why not — stac-utils/rustac#1121
|
@vincentsarago any idea where the slow-down is occurring? |
2 participants
closes #83