Skip to content

fix: update landing page for issue 110 - #111

Merged
devarshishimpi merged 3 commits into
devarshishimpi:devfrom
ananth-kn:fix/issue-110
Sep 18, 2026
Merged

devarshishimpi merged 3 commits into
devarshishimpi:devfrom
ananth-kn:fix/issue-110

Conversation

@ananth-kn

Copy link
Copy Markdown

Summary

Implements #110.

  • Redesigned the login page with a centered modal and dotted background
  • Added the Codra icon and GitHub-only login button
  • Preserved the existing GitHub OAuth flow
  • Added Terms of Service and Privacy Policy links
  • Added responsive behavior for mobile screens

Closes #110

@ananth-kn
ananth-kn changed the base branch from main to dev September 18, 2026 17:27
codra-app-personal[bot]

This comment was marked as resolved.

Comment thread apps/dashboard/src/pages/landing.tsx Outdated

@devarshishimpi devarshishimpi left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing the existing homepage on the / route? Pls revert that change to keep old homepage. Rest it should be good to go for merging.

@codra-app-personal codra-app-personal Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codra Review

Nothing to flag. Reviewed 1 file (237 changed lines) and found no issues worth raising.

Reviewed commit: 340e960f9b

ℹ️ About Codra in GitHub

Your team has set up Codra to review pull requests in this repo. Reviews are triggered when you:

  • Open a pull request for review
  • Mark a draft as ready

Every review posts a summary here. A clean pass also gets a 👍 on the pull request itself.

@devarshishimpi devarshishimpi left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a second thought, this feels like a better UX step. Merging this as it is. Thanks for contributing!

@ananth-kn

Copy link
Copy Markdown
Author

I noticed there’s already a dedicated /login route rendering LoginPage, while the homepage’s existing “Sign in” button goes directly to /auth/github. For Issue #110, should the new sign-in design go on /login, with the homepage “Sign in” linking to /login, or should the homepage continue linking directly to /auth/github and the new design be used elsewhere?

@devarshishimpi
devarshishimpi merged commit 02d099f into devarshishimpi:dev Sep 18, 2026
4 checks passed
@devarshishimpi

Copy link
Copy Markdown
Owner

I was looking at the ideal routing structure for a better experience. The dedicated /login route no longer exists with this PR merged as well. #112

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redesign Login/Signup Page (Modern UI with GitHub OAuth)

2 participants