fix: update landing page for issue 110 - #111
Conversation
There was a problem hiding this comment.
Codra Review
✅ Nothing to flag. Reviewed 1 file (237 changed lines) and found no issues worth raising.
Reviewed commit: 340e960f9b
ℹ️ About Codra in GitHub
Your team has set up Codra to review pull requests in this repo. Reviews are triggered when you:
- Open a pull request for review
- Mark a draft as ready
Every review posts a summary here. A clean pass also gets a 👍 on the pull request itself.
devarshishimpi
left a comment
There was a problem hiding this comment.
On a second thought, this feels like a better UX step. Merging this as it is. Thanks for contributing!
|
I noticed there’s already a dedicated /login route rendering LoginPage, while the homepage’s existing “Sign in” button goes directly to /auth/github. For Issue #110, should the new sign-in design go on /login, with the homepage “Sign in” linking to /login, or should the homepage continue linking directly to /auth/github and the new design be used elsewhere? |
|
I was looking at the ideal routing structure for a better experience. The dedicated Thanks for contributing! |
Summary
Implements #110.
Closes #110