chore: restore make lint (rustfmt + clippy) on main#491
Merged
Conversation
The #488 recovery/device-admission stack landed with rustfmt drift and clippy violations that CI never reported because `make lint` short-circuits at the `cargo fmt --check` step before clippy runs, so the Rust job has been red since 2026-06-05. - cargo fmt --all across 32 drifted files - fix clippy errors: unnecessary `to_vec`, unneeded `return`, manual `is_multiple_of`, and allow `disallowed_methods` in the recovery_anchor test module (matches the existing test convention) Verified locally: `cargo fmt --all -- --check`, `cargo clippy --all-targets -- -D warnings`, and `cargo build --locked --workspace --all-features` all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
main'sRustCI job has been red since 2026-06-05. Root cause: the #488 recovery/device-admission stack merged with rustfmt drift (32 files) and clippy violations. These went unreported becausemake lintrunscargo fmt --all -- --checkfirst and short-circuits beforecargo clippyever executes. Every open PR inherited this failure.What
cargo fmt --all— reformat 32 drifted files (whitespace/line-wrapping only).-D warningserrors surfaced once fmt passed:to_vec(recovery/*), unneededreturn(sdk lib + bitcoin_tap_sdk), manualis_multiple_of(chain_segment)#![allow(clippy::disallowed_methods)]on therecovery_anchortest module (matches existing test convention forunwrap/expect)Verification
Locally green:
cargo fmt --all -- --checkcargo clippy --all-targets -- -D warningscargo build --locked --workspace --all-features