Skip to content

Pass over hidden and disabled widgets in the blocked Tab walk #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rezabakhshilaktasaraei wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pass over hidden and disabled widgets in the blocked Tab walk #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion base/qt/qt_tab_key.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,14 @@ bool FocusNextPrevChildBlocked(not_null<QWidget*> widget, bool next) {
const auto start = focused ? focused : widget.get();
auto w = skip(start);
while (w && w != start) {
if ((w->focusPolicy() & Qt::TabFocus) && widget->isAncestorOf(w)) {
// Like the default traversal: a widget that is hidden or disabled
// is passed over, or Tab lands on something that is not there -
// the field of a collapsed section, or a button shown only while
// its field is focused.
if ((w->focusPolicy() & Qt::TabFocus)
&& w->isVisible()
&& w->isEnabled()
&& widget->isAncestorOf(w)) {
break;
}
w = skip(w);
Expand Down