Repository navigation
feat: support lock reason in user search - #813
Merged
Merged
Conversation
Add lockReasons and tempLockReasons to SearchRequest (descope/etc#18708)
PolinaPrem
force-pushed
the
feat/18708-lock-reason-search
branch
from
October 5, 2026 13:35
d6bd15f to
322f08e
Compare
PolinaPrem
changed the title
PolinaPrem
marked this pull request as ready for review
October 5, 2026 13:42
dorsha
reviewed
Oct 5, 2026
Member
There was a problem hiding this comment.
The request side looks right: both filters pass through search and searchTestUsers and are dropped when unset.
Gap: search returns UserResponse from @descope/core-js-sdk, which has no lockReason / tempLockExpiration (on main or on descope-js#1505). So user.lockReason is a TypeScript error here, while Go, Java and Python expose it. Suggest adding both fields to core-js-sdk's UserResponse (I suggested it on descope-js#1505) and bumping core here before release.
core-js-sdk's UserResponse has no lockReason / tempLockExpiration yet, so UserSearchResponse now uses a node-sdk UserSearchResult that adds both (descope/etc#18708) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
🐕 Shuni ReviewNo new issues found. 🤖 Model: Review scope: Partial incremental re-review Reviewed new changes (3)
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
![shuni-bot[bot]](https://avatars.githubusercontent.com/in/2536750?s=60&v=4){kind=small}
1 of 2 tasks
…stead This reverts commit 4e3ce94. lockReason and tempLockExpiration are added to core-js-sdk's UserResponse in descope/descope-js#1507; core is bumped here once that's released. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Added them to cores UserResponse: descope/descope-js#1507. I'll bump core here once its released. |
dorsha
pushed a commit
to descope/descope-js
that referenced
this pull request
Oct 6, 2026
descope/etc#18708 ## Related PRs - Follow-up to descope/node-sdk#813, which types these fields on search results only, via a node-sdk `UserSearchResult` - Related: #1505 (user management widget lock reason) ## Description The user APIs return two brute-force lock fields that `UserResponse` doesn't type, so SDK consumers can only read them with a cast: - `lockReason?: string` - the auth method that triggered brute-force protection (`password`, `totp`, `recovery_codes`, `security_questions`), empty when none - `tempLockExpiration?: number` - when a temporary lock ends, in unix seconds (0 when none). The user is temporarily locked while this is greater than now Types only. Both fields are optional, so nothing changes for existing callers or for backends that don't return them. Once this is released, node-sdk can drop `UserSearchResult` and `load` and the other user methods get the fields too. ## Must - [x] Tests (existing suite passes; the change is type-only) - [ ] Documentation (if applicable) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
core-js-sdk 2.75.0 adds lockReason and tempLockExpiration to UserResponse (descope/descope-js#1507), so search results expose them (descope/etc#18708) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dorsha
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Related: descope/etc#18708
Description
Adds
lockReasonsandtempLockReasonstoSearchRequest. The deprecated positionalsearchAllis unchanged. The response type lives in core-js-sdk, which needslockReason?: string; tempLockExpiration?: number;onUserResponsein a separate descope-js change.tempLockExpirationis unix seconds (0 when none). A user is temporarily locked whiletempLockExpiration > now. TOTP has no temporary lock, sotempLockReasonsaccepts only password, recovery_codes and security_questions.Must
🤖 Generated with Claude Code