Skip to content

fix: route wildcard cert to DNS-01 issuer so apex SAN avoids HTTP-01 loop #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krist7599555 wants to merge 1 commit into from
+22 −8
Closed

fix: route wildcard cert to DNS-01 issuer so apex SAN avoids HTTP-01 loop #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions k8s/cert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,17 @@ type Certificate struct {
ID string
ProjectID string
Domain string
// Wildcard adds a `*.<Domain>` SAN alongside the apex. The Issuer's solver
// list already routes the wildcard challenge to DNS-01 (Let's Encrypt
// rejects HTTP-01 for wildcards, so cert-manager filters HTTP-01 solvers
// out automatically), so no IssuerRef change is needed.
// Wildcard adds a `*.<Domain>` SAN alongside the apex and routes the whole
// cert through the DNS-01-only ClusterIssuer letsencrypt-dns01.
//
// The shared `letsencrypt` Issuer carries both an HTTP-01 (parapet ingress)
// and a DNS-01 solver. cert-manager only auto-filters HTTP-01 for the
// `*.<Domain>` SAN (Let's Encrypt rejects HTTP-01 for wildcards); the bare
// apex SAN still selects the HTTP-01 solver. For a Cloudflare/CDN-proxied
// domain that challenge can never complete (the request is redirected/404'd
// at the edge and never reaches the parapet solver), so cert-manager retries
// it forever. Pinning wildcard rows to the DNS-01-only issuer makes both the
// apex and the wildcard SAN validate via DNS-01. See deploys-app/deployer#38.
Wildcard bool
}

Expand Down Expand Up @@ -47,19 +54,26 @@ func (c *Client) CreateCertificate(ctx context.Context, obj Certificate) (ready
}

dnsNames := []string{obj.Domain}
issuerRef := cmmeta.ObjectReference{
Name: "letsencrypt",
Kind: v1.IssuerKind,
}
if obj.Wildcard {
dnsNames = append(dnsNames, "*."+obj.Domain)
// DNS-01 for every SAN (apex included) — avoids the HTTP-01 solver that
// never validates behind a CDN. See the Wildcard field comment above.
issuerRef = cmmeta.ObjectReference{
Name: "letsencrypt-dns01",

@acoshift acoshift Aug 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

บน cluster ไม่มี issuer นี้ครับ

Kind: v1.ClusterIssuerKind,
}
}

cert.ObjectMeta.Name = obj.ID
cert.ObjectMeta.Labels = labels
cert.Spec = v1.CertificateSpec{
CommonName: obj.Domain,
DNSNames: dnsNames,
IssuerRef: cmmeta.ObjectReference{
Name: "letsencrypt",
Kind: v1.IssuerKind,
},
IssuerRef: issuerRef,
PrivateKey: &v1.CertificatePrivateKey{
Algorithm: v1.ECDSAKeyAlgorithm,
Size: 256,
Expand Down