Skip to content

feat(scene): support whole-model transparency #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dennisdevulder wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(scene): support whole-model transparency #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions src/main/java/com/gpuvulkan/scene/SceneModelEmitter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ private static final class ModelArrays
byte[] textureFaces;
int[] texA, texB, texC;
byte[] trans, bias;
byte modelTrans;
byte overrideHue, overrideSat, overrideLum, overrideAmount;
boolean hasOverride;

Expand All @@ -93,6 +94,7 @@ boolean load(Model m)
texB = m.getTexIndices2();
texC = m.getTexIndices3();
trans = m.getFaceTransparencies();
modelTrans = m.getTransparency();
bias = m.getFaceBias();
overrideAmount = m.getOverrideAmount();
overrideHue = m.getOverrideHue();
Expand Down Expand Up @@ -199,7 +201,7 @@ private void emitUnsortedFaces(ModelArrays a, int faces,
}

int bias = a.bias != null ? (a.bias[f] & 0xFF) : 0;
int trans = a.trans != null ? (a.trans[f] & 0xFF) : 0;
int trans = effectiveTransparency(a.modelTrans, a.trans != null ? (a.trans[f] & 0xFF) : 0);
// Static sweeps split faces by transparency; 255 is the engine
// invisibility sentinel and is dropped from static capture.
if (staticFaceFilter == FILTER_OPAQUE && trans != 0) continue;
Expand Down Expand Up @@ -282,14 +284,17 @@ void captureModelSorted(Projection proj, Model m, int orient, int worldX, int wo
int priorityStart = prioritySort ? sink.currentVertexCount() : -1;
int faceCount = m.getFaceCount();
byte[] faceTransparencies = m.getFaceTransparencies();
if (!prioritySort && faceCount <= OPAQUE_UNSORTED_FACE_THRESHOLD
// Whole-model transparency is per-renderable and can change every
// frame, so it stays out of the face cache key.
boolean modelTransparent = m.getTransparency() != 0;
if (!prioritySort && !modelTransparent && faceCount <= OPAQUE_UNSORTED_FACE_THRESHOLD
&& ModelFaceCache.countTransparentFaces(faceCount, faceTransparencies) == 0)
{
captureModelUnsorted(m, orient, worldX, worldY, worldZ);
return;
}
ModelFaceCache.Entry modelInfo = modelFaceCache.info(faceCount, faceTransparencies);
boolean needsFaceSort = prioritySort || modelInfo.hasTransparentFaces;
boolean needsFaceSort = prioritySort || modelInfo.hasTransparentFaces || modelTransparent;
if (!needsFaceSort && modelInfo.faceCount <= OPAQUE_UNSORTED_FACE_THRESHOLD)
{
captureModelUnsorted(m, orient, worldX, worldY, worldZ);
Expand Down Expand Up @@ -420,7 +425,7 @@ private void emitSortedFaces(ModelArrays a, int faces, boolean detailedStats)
}

int bias = a.bias != null ? (a.bias[f] & 0xFF) : 0;
int trans = a.trans != null ? (a.trans[f] & 0xFF) : 0;
int trans = effectiveTransparency(a.modelTrans, a.trans != null ? (a.trans[f] & 0xFF) : 0);
int packedTexLayer = texLayer | (bias << 16) | (trans << 24);
boolean noUv = texLayer == 0;

Expand Down Expand Up @@ -481,6 +486,23 @@ private void emitSortedFaces(ModelArrays a, int faces, boolean detailedStats)
emitUvNanos = uvNanos;
}

/** Stock GPU parity: fold whole-model transparency into each face's
* alpha. -1 is the engine's invisible sentinel; 253+ face values are
* already sentinels and pass through untouched. */
private static int effectiveTransparency(byte modelTransparency, int faceTransparency)
{
if (modelTransparency == -1)
{
return 255;
}
int t = modelTransparency & 0xFF;
if (t > 0 && faceTransparency < 253)
{
return faceTransparency + (((253 - faceTransparency) * t) >> 8);
}
return faceTransparency;
}

private void recordPriorityRange(int start)
{
priorityRanges.record(start, sink.currentVertexCount());
Expand Down Expand Up @@ -659,7 +681,7 @@ private void emitCulledFaces(ModelArrays a, int faceCount, boolean detailedStats
}

int bias = a.bias != null ? (a.bias[f] & 0xFF) : 0;
int trans = a.trans != null ? (a.trans[f] & 0xFF) : 0;
int trans = effectiveTransparency(a.modelTrans, a.trans != null ? (a.trans[f] & 0xFF) : 0);
int packedTexLayer = texLayer | (bias << 16) | (trans << 24);
boolean noUv = texLayer == 0;

Expand Down