docs(agents-md): spell out full systemctl path in sudo examples - #354
Conversation
Bare `sudo systemctl reload caddy.service` / `sudo systemctl start agent-box-update.service`, as literally shown in the guide, resolve `systemctl` through the agent's PATH to a Nix store path — which the sudoers rule (keyed on the absolute /run/current-system/sw/bin/systemctl path) doesn't match, so the command silently falls back to asking for a password instead of running passwordlessly. Update the guide text (modules/src/default-agents.md), the matching option descriptions in modules/agent-box.nix.in, regenerate modules/agent-box.nix, and refresh the golden fixture. Fixes #353 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GPscnUVnoHcT6iEjMEjx9n
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe change updates agent instructions, NixOS option descriptions, and golden guide files to use ChangesSystemctl path guidance
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change updates copied systemctl commands to use the sudoers-matching absolute path and refreshes the corresponding generated documentation. No actionable merge-blocking risk remains after the listed checks. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
sudo systemctl reload caddy.service/sudo systemctl start agent-box-update.service. Baresystemctlresolves through PATH to a Nix store path, which the sudoers rule — keyed on the absolute/run/current-system/sw/bin/systemctlpath — doesn't match, so the copy-pasted command silently falls back to a password prompt instead of running.modules/src/default-agents.md(the guide text) and the matching option descriptions inmodules/agent-box.nix.into show the full path, with a one-line note explaining why the exact path matters.modules/agent-box.nixand refreshedtests/golden/*/etc/agent-box-guides/AGENTS.agent.mdto match.Test plan
python3 tests/test-assemble-module.pynix build -L .#checks.aarch64-linux.module-generated-up-to-datenix build -L .#checks.aarch64-linux.assemble-module-escapingnix build -L .#checks.aarch64-linux.golden-snapshotFixes #353
🤖 Generated with Claude Code
https://claude.ai/code/session_01GPscnUVnoHcT6iEjMEjx9n