addAssumeNotIn for faster add - #32
Open
PauSolerValades wants to merge 1 commit into
Open
PauSolerValades wants to merge 1 commit into
PauSolerValades wants to merge 1 commit into
Conversation
…ed for those methods
Owner
|
Looks like we have conflicts on this PR. But also, I'm not yet sure if this API makes sense to have in this repo. I want this repo to be a generally performant but also straightforward by not having too many API methods. If you are trying to squeeze every bit of performance out of it, it might be better to model your own Set data-structure precisely. I'm still thinking about it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I propose to add this function as an dangerous alternative to a faster add. It does not return a bool as it does not check if the element was there or not. I needed this to maximize performance in
ReleaseFast, asputNoClobberin debug asserts a lot (slower) but in release skips the checks to return the bool.I am porting this from my another repo which i was trying to get as much performance as possible :)