osoji sweep: fix 122 verified documentation and code findings - #202
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…comments, dead code, latent bugs) Exhaustive re-triage of a full osoji audit (232 warning/error findings, every one read in place, false-positive calls adversarially verified). Applied the 122 verified true positives: documentation corrected against actual code behavior, stale comments rewritten, dead code removed, latent bugs fixed. Full CI suite green: 2619 passed / 18 skipped. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… fix ruby version-probe race
Review findings on the sweep:
- adapter-development-guide: the dynamic loader imports the named factory
export only; the default export is a convenience, not a requirement
(adapter-loader.ts reads moduleRef[factoryClassName]). Also
BaseAdapterFactory provides getMetadata()/validate() only, no
version-compat helpers.
- dependency-injection: adapters receive AdapterDependencies, not
IProxyProcessLauncher (which ProxyManagerFactory/ProxyManager consume).
- component-design: evaluateExpression's 4th param is timeoutMs.
- comprehensive-mcp-tools e2e: restore the step_out pass/fail expression;
the simplified form passed whenever message was undefined, which is
exactly what the server's {success:false, error} envelope produces.
- ruby-utils: resolve version probes on 'close' instead of 'exit' so
stdio is drained before reading output — 'exit' can fire with pending
stdout data, making getRdbgVersion return null on loaded CI runners
(the exact one-test failure on this PR's previous CI run).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
An exhaustive osoji audit sweep (232 warning/error findings, every one re-triaged in place with adversarial verification of dismissals) followed by fixes for all 122 verified true positives:
Also scopes future osoji audits away from
docs/archive/**via.osoji.toml.Verification
pnpm run test:ci).Fix authorship: each fix was drafted by a triage agent that read the finding in place, applied by a separate agent, and the whole set gated on the project's own test suite.
🤖 Generated with Claude Code