Build helper to_sf()#73
Open
mdsumner wants to merge 3 commits into
Open
Conversation
Owner
|
Thanks. I see this is one step towards what I had in mind for #25 I'm going to leave this as a PR until I finalise how the C++ API will work, then the R side (your code) will fit onto that. |
Contributor
Author
|
Ah no worries - I'll just use this externally for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A next level helper, this one determines the
sfctype by matching sets of available column names, and detecting geometry type.Is this suitable for sfheaders? I'm not sure - if not I'll build it into silicate, or into a tiny new package importing sfheaders.