Skip to content

Upgrade dependencies, go fmt, fixed whitespace handling, switched t… - #86

Closed
SamuelMarks wants to merge 3 commits into
dave:masterfrom
SamuelMarks:upgrade-ghactions-whitespace-new-syntax-support
Closed

SamuelMarks wants to merge 3 commits into
dave:masterfrom
SamuelMarks:upgrade-ghactions-whitespace-new-syntax-support

Conversation

@SamuelMarks

Copy link
Copy Markdown
Contributor

Changelog:

  • Upgraded dependencies
  • go fmt
  • Fixed whitespace handling (Fprint can eat empty lines. #81)
  • Switched to GitHub Actions
  • Add docstrings
  • Generic type aliases (type A[T any] = B[T])
  • //go:build directives and GoVersion file metadata
  • Iterator syntax (range over func)

#85

@SamuelMarks

Copy link
Copy Markdown
Contributor Author

@dave @snakeice THis is approved! - Can you merge?

@dave

dave commented Sep 10, 2026

Copy link
Copy Markdown
Owner

Thanks for this @SamuelMarks, and sorry for the slow reply.

I've opened #88, which takes the core of your work — the dependency upgrade, the Actions migration, the gofmt pass, the vet example renames and the #81 fix — with your authorship on those commits. I kept it narrow because the library has a lot of users and I wanted the smallest change that gets us current.

Two things you'll want to know:

  1. x/tools v0.41.0 can't read the export data Go 1.27 emits — it fails with export data version 4 is greater than maximum supported version 2 in the gotypes and gopackages resolvers. V4 support landed in v0.44.0; Upgrade for current Go releases #88 uses v0.50.0.

  2. The mangled doc comments in your decorations-types-generated.go weren't your fault. gendst sliced positions.go using token.Pos values that are relative to the file's base in the FileSet, and go/loader parses a package's files concurrently — so regenerating could silently corrupt that file or panic outright. Upgrade for current Go releases #88 fixes it.

I left out the TypeSpec Assign change. You're right that the = is mis-ordered for generic aliases, but it adds a public decoration point and moves comment attachment from Name to Assign for all aliases, which is a behaviour change for existing users. Worth doing on its own — happy to look at a PR for just that.

I also skipped the added docstrings, and restored the file-level skips in the stdlib test rather than skipping runtime/reflect/internal/godebug wholesale, since that test is the main regression guard.

Closing this in favour of #88 — thanks again for the push to get this up to date.

@dave dave closed this Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants