Conversation
The cell controller creates one claim per attachment whose network declares internet egress, once the attachment has reported its node, and deletes it when the declaration is withdrawn. The node's installer lists the claims naming it on every sweep and keeps each VRF's egress route in step, so egress can be turned on or off for a running workload without re-attaching it. The claim also records the binding: status names the shard on the node, and the Ready condition says why a claim is not bound. Key changes: - Spec carries the attachment, its VPC, the node and the families, and is immutable, so a moved attachment gets a new claim - A node label restates the node so an installer can list its claims server-side, and a shard label lists a shard's consumers - Chainsaw test covers the required fields, the family enum, spec immutability and a writable status Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turning internet egress on or off for a network today only takes effect on a workload when it is attached again, because the node learns the declaration once, at attach time.
This adds an EgressShardClaim: one per attachment, written by the cell controller while the attachment's network declares egress and deleted when it stops. A node's installer lists the claims naming it and keeps each VRF's egress route in step, so a live toggle converges without touching the workload.
The claim also records which shard the attachment leaves through, and says why it is not bound when it isn't.
Test plan
Related to datum-cloud/network-services-operator#475
🤖 Generated with Claude Code