fix(iam): make IPAM read-only for organization members - #297
Merged
Merged
Conversation
Organization owners inherited ipam.miloapis.com-admin, which carries pool and class CRUD. Every customer is the owner of the organization they create, so every customer could create and delete IP pools and classes in any of their projects. Address space is platform-operated: a pool's CIDR cannot be corrected once an address has been handed out of it. Owner drops the admin grant. Viewer gains ipam.miloapis.com-viewer, which editor and owner both inherit, so members can see the pools and allocations backing their networks where before only owners could. Allocation is unaffected: claims are filed by the network operator under its own identity, not the end user's.
scotwells
marked this pull request as ready for review
September 23, 2026 00:06
drewr
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The datum-cloud owner role inherits
ipam.miloapis.com-admin, which carries pool and class CRUD. Every customer owns the organization they create, and that binding reaches every project in it — so every customer can create and delete IP pools and classes in their own projects. A pool's CIDR cannot be corrected once an address has been handed out of it, and deleting one orphans every allocation beneath it.editor and viewer name no IPAM role at all, so a non-owner member cannot even list the pools their networks draw from.
Change
Owner drops
ipam.miloapis.com-admin. Viewer gainsipam.miloapis.com-viewer, which editor and owner inherit — all three end up read-only.Allocation is unaffected: claims are filed by the network operator under its own identity, and provisioned pools are created by the IPAM service itself.
Left out
Platform operators have no IAM route to IPAM either — the platform pools are installed by a
system:masterscertificate. datum-cloud/infra#5903 grants themipam.miloapis.com-provider, scoped to the Datum organization.