Conversation
Workload deployment names joined the workload, placement and location names, so a long enough combination passed 63 characters and the objects that run the workload were rejected. Two workloads could also produce the same name. Key changes: - Name deployments with the first 30 characters of the workload name and a 10-character hash of the workload UID, placement and location, so length never depends on placement or location and names never collide - Orphan every deployment of the workload that does not carry a desired name, which replaces deployments created under the old naming - Refuse to update a deployment that belongs to another workload - Require a DNS-1123 label workload name on create; updates are unaffected
scotwells
force-pushed
the
feat/367-bounded-deployment-names
branch
from
September 25, 2026 20:38
2225332 to
18b34c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workloads with long names never start, because compute builds internal names from the workload, placement and location names and passes the 63-character limit with workload names as short as 40 characters.
Internal deployment names now use a readable piece of the workload name plus a short hash, so they never exceed 41 characters and two workloads can never share one. Deployments under any other name, including ones created before this change, are replaced, and a deployment belonging to another workload is never overwritten.
New workloads must have a valid DNS label name of up to 63 characters, so a bad name is refused at create time instead of failing silently.
Test plan
Related to #367