Conversation
Instances are created and owned by controllers, so the compute admin role only granted read access to them. That left operators unable to remove a stale finalizer from an Instance whose controller had been retired: no role in the platform held instances.patch or instances.update, so even an organization owner needed break-glass credentials. Grant update and patch on Instances to compute.datumapis.com-admin. The Instance ProtectedResource already declares both verbs. Create and delete stay with the controllers that own the Instance lifecycle.
scotwells
marked this pull request as ready for review
September 24, 2026 19:14
ecv
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an Instance is left holding a finalizer from a controller that no longer runs, nobody in the project can clear it without break-glass credentials. The compute admin role only reads Instances, and no role on the platform grants the write needed to edit one, so even an organization owner is blocked. This change lets a project's compute admins update and patch Instances, so an operator can remove a stuck finalizer with ordinary credentials. Creating and deleting Instances stays with the controllers that own them.
Change
Adds two permissions to the Compute Admin role:
compute.datumapis.com/instances.updatecompute.datumapis.com/instances.patchThe Instance protected resource already declares both verbs, so no other IAM change is needed.
Context
Three Instances in staging still carry the retired
compute.datumapis.com/infra-provider-gcpfinalizer and cannot be cleaned up through IAM today.Instances are a projection the compute operator maintains, so an admin's edit to their spec may be overwritten on the next reconcile. The intended use is metadata cleanup such as finalizers.
Related to datum-cloud/infra#5980
Test plan