Skip to content

make downloader more robust#666

Open
jshook wants to merge 1 commit into
mainfrom
download_defense
Open

make downloader more robust#666
jshook wants to merge 1 commit into
mainfrom
download_defense

Conversation

@jshook
Copy link
Copy Markdown
Contributor

@jshook jshook commented May 14, 2026

This does a couple things to make downloads more defensive:

  1. Recognizes when multiple (dataset,facet) configs point to the same file and
    • for query vectors, allows it
    • for base vectors, throws an error (for now, this is not supported without windowed reads)
    • for ground truth vectors, throws an error
  2. Recognizes when different instances of the same logical (dataset,facet) config points at potentially different paths.
    • This is a hard error. Before, this was a first-finder wins scenario, which is non-deterministic.
    • For scenarios where a single file was shared, make the downloader concurrently safe.
    • Before it was possible for two different threads to use the same physical output buffer, but only with S3.

These are defensive changes which simply cause these types of errors to be surfaced. The bias here is to avoid surprises or non-deterministic results.

@github-actions
Copy link
Copy Markdown
Contributor

Before you submit for review:

  • Does your PR follow guidelines from CONTRIBUTIONS.md?
  • Did you summarize what this PR does clearly and concisely?
  • Did you include performance data for changes which may be performance impacting?
  • Did you include useful docs for any user-facing changes or features?
  • Did you include useful javadocs for developer oriented changes, explaining new concepts or key changes?
  • Did you trigger and review regression testing results against the base branch via Run Bench Main?
  • Did you adhere to the code formatting guidelines (TBD)
  • Did you group your changes for easy review, providing meaningful descriptions for each commit?
  • Did you ensure that all files contain the correct copyright header?

If you did not complete any of these, then please explain below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant