Add array and matrix to lengthDS permitted classes#483
Merged
Conversation
Member
|
Looks like RoxygenNote needs to be set to "8.0.0" |
StuartWheater
approved these changes
Jun 1, 2026
Member
StuartWheater
left a comment
StuartWheater
left a comment
There was a problem hiding this comment.
The documentation indicates "x" should resolve to a vector or list, which does not match the test, but R appears to permit "x" to be just about anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
I added class checks on the serverside for
lengthDS, but was too restrictive which showed up in a failing clientside check.Solution
Add array and matrix as permitted classes.