Skip to content

Refactor agent and enterprise settings tabs#568

Merged
yaojin3616 merged 3 commits into
mainfrom
fix_agent_detail_optimize
May 13, 2026
Merged

Refactor agent and enterprise settings tabs#568
yaojin3616 merged 3 commits into
mainfrom
fix_agent_detail_optimize

Conversation

@yaojin3616
Copy link
Copy Markdown
Collaborator

Summary

  • split AgentDetail tab content into dedicated tab components
  • extract EnterpriseSettings org, skills, okr, and llm tabs into enterprise-settings modules
  • move enterprise info helpers and shared fetch helper into dedicated components/utils

Testing

  • bundled frontend/src/pages/EnterpriseSettings.tsx with esbuild to catch module and syntax errors

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b21b1b4bb2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread frontend/vite.config.ts
proxy: {
'/api': {
target: 'http://localhost:8008',
target: 'http://localhost:8000',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore Vite API proxy to the source backend port

Pointing the Vite /api and /ws proxies to port 8000 breaks local source-mode development, because restart.sh starts the backend on 8008 (BACKEND_PORT=8008). In that common flow (bash restart.sh / --source), frontend requests now proxy to a non-listening port and fail with connection errors, so the UI cannot reach the API unless users manually change their backend port.

Useful? React with 👍 / 👎.

@yaojin3616 yaojin3616 merged commit 967dbec into main May 13, 2026
0 of 2 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a2022a862d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +497 to +499
const imgRef = useRef<HTMLImageElement>(null);
const [naturalSize, setNaturalSize] = useState({ width: 1, height: 1 });
const [zoom, setZoom] = useState(1);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove non-Skills components from SkillsTab module

This file now includes copied company-identity editor code after the SkillsTab export, but its imports only bring in useMemo/useState; the appended section uses useRef, useEffect, useQueryClient, fetchJson, and other symbols that are not imported here. Because the frontend build runs tsc (frontend/package.json), this introduces TypeScript compile failures and blocks production builds even though the extra functions are unrelated to the Skills tab.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant