[Rust] Fall back to system protoc - #819
Open
notpeter wants to merge 1 commit into
Open
Conversation
Signed-off-by: Peter Tripp <petertripp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why: On Illumos current repo will fail at build time because
rust-protoc-bin-vendoredcannot find aprotocbinary. After this change, build will succeed if there's a suitableprotocin your path or aPROTOCenvironment variable set with a suitable path. This makes it possible to compile zerobus-sdk on Illumos.Changes:
protocbinaries.protocover fetching a pre-built binary from Google.Upstream:
How is this tested?
I have tested this change building locally on OmniOS as well as running the full test suite under CI on my fork.
Passing run here.
If you would like to add Illumos to your test suite (via vmactions/omnios-vm, happy to add that here too.
Similarly vmactions/freebsd-vm also exists.