fix nested config items in codex app - #493
Closed
lilly-luo wants to merge 2 commits into
Closed
Conversation
lilly-luo
force-pushed
the
lilly/fix-codex-app-again
branch
from
September 4, 2026 22:01
d938d39 to
8d6d2c2
Compare
Collaborator
Author
|
this will be fixed here: #502 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#473 was a previous attempt to fix codex app in ucode. i tested by running
uv run ucode codex appand it worked. however, when i installed a new ucode and ranucode codex app, it failed with the error below.this is because when i tested previously,
uv runuses the uv.lock where as a freshly installed ucode does not respect uv.lock. we specify tomlkit>=0.13.0. the uv.lock has 0.14 pinned which works but a freshly installed ucode has tomlkit 0.15.1 which is not compatible with this change.i've since updated the uv.lock #496 so that uv run will be consistent with future installs so we don't have this discrepancy in the future. this PR makes a fix such that
ucode codex appwill actually workbefore:
after (with the updated uv.lock):