docs: correct connection parameter reference - #943
Merged
Conversation
vuanhphung
had a problem deploying
to
azure-prod
September 4, 2026 23:06 — with 
GitHub Actions
Error
GitHub Actions
Error
vuanhphung
had a problem deploying
to
azure-prod
September 4, 2026 23:06 — with
GitHub Actions
Error
GitHub Actions
Error
vuanhphung
force-pushed
the
docs/fix-connection-parameter-reference
branch
from
September 4, 2026 23:09
f10f961 to
87c3aff
Compare
vuanhphung
temporarily deployed
to
azure-prod
September 4, 2026 23:09 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
September 4, 2026 23:09 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
September 4, 2026 23:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verdict: 1 Low
Looks good — a well-researched documentation correction whose technical claims I spot-checked against session.py, client.py, and backend/kernel/client.py and found accurate (notably the _telemetry_circuit_breaker_enabled effective-False Thrift default, kernel header filtering, force_enable_telemetry not being forwarded to Kernel, and shared-cursor use_inline_params rendering). One low-severity completeness note inline.
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
vuanhphung
force-pushed
the
docs/fix-connection-parameter-reference
branch
from
September 5, 2026 00:53
87c3aff to
79ed6de
Compare
vuanhphung
temporarily deployed
to
azure-prod
September 5, 2026 00:53 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
September 5, 2026 00:53 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
September 5, 2026 00:53 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the connection parameter reference to include missing routing and header options and align its Thrift/Kernel support matrix with the current implementations.
Corrects stale behavior and default claims for authentication, HTTP/retries, inline parameters, and telemetry, then refreshes the summary and connector version.
Testing: git diff --check.