Conversation
Signed-off-by: Cathleen Yan <58714163+cathleeny@users.noreply.github.com>
Collaborator
Author
|
Superseded by #492, which uses an upstream branch so repository CI credentials are available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithKernelGeospatialAsStringandgeospatialAsStringfor kernel-backed GEOMETRY / GEOGRAPHY resultsdatabase/sqlin binary mode while preserving the canonical{srid,wkb}Arrow struct throughGetArrowBatchesDependency
Depends on databricks/databricks-sql-kernel#361 at
ad3bc6993bca95b810839feade77ccd0ab98ece5.Keep this PR in draft until #361 is merged and a kernel bindings version containing that commit is available. The released per-platform Go kernel modules remain at 1.1.0 today; this PR intentionally does not invent a prerelease bindings version.
Validation
golangci-lint: 0 issuesgo test ./...: passedgo test ./...against the exact [ES-1911239] Retry transient S3 errors on staging PUT/GET/REMOVE #361 rustls archive: passed