Move logging setup out of __init__.py - #279
Merged
Merged
Conversation
khoroshevskyi
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing bedhost used to configure logging as a side effect.
__init__.pycalledlogmuse.init_logger()and forced bbconf and geniml to DEBUG, so anything that imported the package got that whether it wanted it or not.That belongs at the entry point instead. bedhost runs under
uvicorn bedhost.main:app, somain.pyis the entry point and the setup moved there unchanged.main()was not an option, since the CLI is not how the server is actually started.__init__.pynow just doeslogging.getLogger(PKG_NAME), which keeps the existingfrom . import _LOGGERimports in helpers.py, main.py, and bed_api.py working. It is the same logger object that main.py configures, so startup logging is unaffected.Requires logmuse 0.3.0.
Unrelated, noticed while working here and not fixed in this PR:
cli.pyrefers toCFG_ENV_VARS, which is not defined or imported anywhere, sobuild_parser()raises NameError andbedhost servedoes not run. It has been that way for a while, which fits with everything going through uvicorn instead.