Bump up version - remove snapshot from 1.11.13#663
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project version from 1.11.13-SNAPSHOT to 1.11.13 across all database plugin modules and the parent POM. Additionally, it increments the cdap-e2e-framework dependency version from 0.3.0 to 0.3.2 in the root pom.xml. There are no review comments to address, and I have no feedback to provide.
Vipinofficial11
force-pushed
the
remove-snapshot-1.11.13
branch
2 times, most recently
from
2eb5574 to
3b0d86e
Compare
Vipinofficial11
force-pushed
the
remove-snapshot-1.11.13
branch
from
3b0d86e to
7ec69d6
Compare
| <groupId>io.cdap.tests.e2e</groupId> | ||
| <artifactId>cdap-e2e-framework</artifactId> | ||
| <version>0.3.0</version> | ||
| <version>0.5.0-SNAPSHOT</version> |
There was a problem hiding this comment.
This is not correct, the tests will get executed on develop branch of cdap-e2e-tests but this branch should run against release/6.10 branch of cdap-e2e-tests.
There was a problem hiding this comment.
Yes, Ideally this branch should be running against a stable release of the e2e framework (like release/6.10).
There were some test failures on this PR so did some debugging, here is what is happening under the hood based on my current understanding :
- In our .github/workflows/e2e.yml, the step that clones cdapio/cdap-e2e-tests doesn't specify a branch ref because of this, GitHub Actions defaults to pulling the develop branch (attached a ss of this below)
-
Since the action clones develop branch, it executes the newest version of the Python runner script. This script automatically pulls and spins up the latest CDAP Sandbox
-
Now the pipeline forces the tests to run against the newest CDAP UI, leaving the framework dependency on an older version results in failures (the UI locators and error message assertions are totally out of sync).
Please share if I missed something and this is not the case on how things are actually working in the existing setup.
There was a problem hiding this comment.
This is incorrect, we should specify the branch in github actions as release/6.10 here : https://github.com/data-integrations/database-plugins/blob/release/1.11/.github/workflows/e2e.yml#L67
For example in google-cloud : https://github.com/data-integrations/google-cloud/blob/release/0.24/.github/workflows/e2e.yml#L64
There was a problem hiding this comment.
I see, got it. Will raise a separate PR to checkin the Github Action change to define the release version of cdap-e2e-tests.
4 participants
Bump up - Remove snapshot from 1.11.13
Update cdap-e2e-framework version to 0.3.2