Reject arrays in deeply nested asarray inputs - #247
Open
mikamikasuki wants to merge 1 commit into
Open
mikamikasuki wants to merge 1 commit into
mikamikasuki wants to merge 1 commit into
Conversation
Author
|
The Python 3.14 / development-NumPy failure in |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asarray([xp.asarray(1)])rejects nested Arrays, butasarray([[xp.asarray(1)]])silently accepts them because the check only examines the outer sequence.Recursively inspect lists and tuples so the existing strictness applies at every nesting level. Standalone Array and buffer inputs continue through their existing conversion paths. This extends the behavior introduced in #147; it does not impose a new requirement on the Array API specification.
Added 17 rejecting cases and four scalar-sequence controls. The full suite passes with NumPy 2.5.3 (791 passed) and NumPy 1.26.4 (790 passed, 1 skipped), and Ruff passes. Independent checks cover 378 nested Array inputs, 126 nested scalar inputs, and three buffer inputs.
Fixes #245.
Prepared with AI assistance.