Skip to content

DAOS-19001 vos: set dth_need_validation when evict active DTX#18346

Merged
gnailzenh merged 1 commit into
masterfrom
Nasf-Fan/DAOS-19001
Jun 2, 2026
Merged

DAOS-19001 vos: set dth_need_validation when evict active DTX#18346
gnailzenh merged 1 commit into
masterfrom
Nasf-Fan/DAOS-19001

Conversation

@Nasf-Fan
Copy link
Copy Markdown
Contributor

There is race condition between IO RPC handler and DTX resync that may commit or abort the DTX when related DTX leader waiting for non-leader participants. To properly handle such case, anytime when an active DTX entry is evicted from the cache, in spite of it is for commit or abort, we need to set dtx_handle::dth_need_validation to notify the DTX owner about the event.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 25, 2026

Ticket title is 'vos_dtx_mark_committable() Assertion 'dae != NULL' failed'
Status is 'In Progress'
Labels: 'test_2.6.5rc1'
https://daosio.atlassian.net/browse/DAOS-19001

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-19001 branch 2 times, most recently from c68e312 to 5a0cf9c Compare May 25, 2026 09:51
There is race condition between IO RPC handler and DTX resync that may
commit or abort the DTX when related DTX leader waiting for non-leader
participants. To properly handle such case, anytime when an active DTX
entry is evicted from the cache, in spite of it is for commit or abort,
we need to set dtx_handle::dth_need_validation to notify the DTX owner
about the event.

Signed-off-by: Fan Yong <fan.yong@hpe.com>
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-19001 branch from 5a0cf9c to 99677c1 Compare May 26, 2026 14:01
@daosbuild3
Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18346/4/testReport/

@Nasf-Fan
Copy link
Copy Markdown
Contributor Author

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18346/4/testReport/

test_dfuse_daos_build_wb failed for DAOS-19024, not related with the patch.

@Nasf-Fan Nasf-Fan marked this pull request as ready for review May 28, 2026 10:15
@Nasf-Fan Nasf-Fan requested review from a team as code owners May 28, 2026 10:15
@Nasf-Fan Nasf-Fan requested review from gnailzenh and liuxuezhao May 28, 2026 10:15
@gnailzenh gnailzenh merged commit 7c00768 into master Jun 2, 2026
39 of 41 checks passed
@gnailzenh gnailzenh deleted the Nasf-Fan/DAOS-19001 branch June 2, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants