Skip to content

fix(state-machine): catch-all block_timer_expires -> idle to prevent stuck-in-blocked #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pluskal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(state-machine): catch-all block_timer_expires -> idle to prevent stuck-in-blocked #336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions custom_components/entity_controller/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,18 @@ async def async_setup(hass, config):
dest="idle",
conditions=["is_state_entities_on", "is_duration_sensor", "is_sensor_off"],
)
# Catch-all: block_timer_expires -> idle for every case the conditional
# transitions above do not handle. Without it the controller stays stuck in
# `blocked` past its block_timeout when the timer fires and state entities
# are still reported as on (e.g. slow cloud/gateway feedback from
# integrations like Overkiz/Tahoma) while the trigger sensor is already off,
# or when state entities are off but no earlier transition matches. Added
# last so the conditional "go to active" rules are evaluated first.
Comment on lines +333 to +339
machine.add_transition(
trigger="block_timer_expires",
source="blocked",
dest="idle",
)
Comment on lines +340 to +344

# Active Timer
machine.add_transition(
Expand Down