Skip to content

fix(time): futurize() must compare in HA-local wall time, not OS timezone #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pluskal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(time): futurize() must compare in HA-local wall time, not OS timezone #335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions custom_components/entity_controller/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1690,12 +1690,24 @@ def futurize(self, timet):

# self.log.debug("-------------------- futurize ------------------------")
# self.log.debug("Input (naive) %s ", timet)
today = date.today()
# Compare in HA-local wall time, NOT the process timezone: parse_time()
# returns naive times in the HA-configured timezone, while
# datetime.now()/date.today() follow the OS timezone. When the two
# differ (e.g. host on UTC, HA on Europe/Prague), a just-fired callback
# rescheduled itself to a time that is "future" in OS terms but already
# past in HA-local terms — async_track_point_in_time then fires it
# again immediately, in an endless loop (2026-07-09 incident: sunrise
# end_time callbacks re-fired for exactly the UTC-offset window,
# flooding MQTT with turn_off commands).
now_local = dt.as_local(dt.now()).replace(tzinfo=None)
today = now_local.date()
try:
t = datetime.combine(today, timet)
except TypeError as e:
t = timet
x = datetime.now()
if t.tzinfo is not None:
t = dt.as_local(t).replace(tzinfo=None)
x = now_local
# self.log.debug("input time: " + str(t))

# self.log.debug("current time: " + str(x))
Expand Down